FAQFAQ SearchSearch MemberlistMemberlist UsergroupsUsergroups RegisterRegister
ProfileProfile Log in to check your private messagesLog in to check your private messages Log inLog in

 
Lots of XDF files have lost line breaks.

 
Post new topic   Reply to topic    TunerPro User Forum Forum Index -> Report A Bug
 
Turbosport



Joined: 26 Jun 2006
Posts: 48

PostPosted: Sat Mar 26, 2016 12:29 pm    Post subject: Lots of XDF files have lost line breaks. Reply with quote

Looks like a lot of our xdf files have been uploaded without a text/ascii mode enabled on the ftp client and so have lost their line breaks, for instance:

This one is fine:
http://www.tunerpro.net/download/bindefs/Volkswagen/Golf_VR6_ecu117_soft529.xdf


this one has lost its line breaks

http://www.tunerpro.net/download/bindefs/Volkswagen/VW_OBD1_ABA.xdf

about 30% of all files are the same by the looks of it.
Back to top
View user's profile Send private message
 

 
Mangus
TunerPro Author


Joined: 19 Mar 2003
Posts: 1810

PostPosted: Mon Mar 28, 2016 11:31 am    Post subject: Reply with quote

I'm seeing line breaks (/r/l) in those files just fine.
_________________
***************************************
TunerPro Author
1989 Trans Am
Back to top
View user's profile Send private message
 

 
Turbosport



Joined: 26 Jun 2006
Posts: 48

PostPosted: Mon Mar 28, 2016 11:53 am    Post subject: Reply with quote

Not in chrome on both Windows 10 or MAC ??

Here is what I get in page source, so the files are in a different format:



[img]http://media2.turbosport.co.uk/2013/11/2016032822528086921Screen Shot 2016-03-28 at 21.51.26.png[/img]


[img]http://media2.turbosport.co.uk/2013/11/2016032822527105270Screen Shot 2016-03-28 at 21.51.11.png[/img]
Back to top
View user's profile Send private message
 

 
Mangus
TunerPro Author


Joined: 19 Mar 2003
Posts: 1810

PostPosted: Mon Mar 28, 2016 11:56 am    Post subject: Reply with quote

Those screenshots look fine to me, clearly showing that lines are broken. Also, view them in your favorite hex editor and note that they clearly have line breaks.
_________________
***************************************
TunerPro Author
1989 Trans Am
Back to top
View user's profile Send private message
 

 
Turbosport



Joined: 26 Jun 2006
Posts: 48

PostPosted: Mon Mar 28, 2016 11:57 am    Post subject: Reply with quote

Mangus wrote:
Those screenshots look fine to me, clearly showing that lines are broken. Also, view them in your favorite hex editor and note that they clearly have line breaks.


Sorry they are not screen shots they are page source screen shots hold on.
Back to top
View user's profile Send private message
 

 
Turbosport



Joined: 26 Jun 2006
Posts: 48

PostPosted: Mon Mar 28, 2016 11:58 am    Post subject: Reply with quote

This is a screen shot of the link clicked directly -

By the way a guy I was helping with an xdf spotted this, I just thought I woudl follow it up so its not just me Wink

[img]http://media2.turbosport.co.uk/2013/11/2016032822578657433Screen Shot 2016-03-28 at 21.57.35.png[/img]
Back to top
View user's profile Send private message
 

 
Mangus
TunerPro Author


Joined: 19 Mar 2003
Posts: 1810

PostPosted: Mon Mar 28, 2016 11:59 am    Post subject: Reply with quote

Open them in a hex editor. Search for 0x0d 0x0a (newline and carriage return characters). Note that they exist.

Do the files fail to open in TunerPro?
_________________
***************************************
TunerPro Author
1989 Trans Am
Back to top
View user's profile Send private message
 

 
Turbosport



Joined: 26 Jun 2006
Posts: 48

PostPosted: Mon Mar 28, 2016 11:59 am    Post subject: Reply with quote

and why are my image tags not working ?
Back to top
View user's profile Send private message
 

 
Mangus
TunerPro Author


Joined: 19 Mar 2003
Posts: 1810

PostPosted: Mon Mar 28, 2016 12:00 pm    Post subject: Reply with quote

Turbosport wrote:
This is a screen shot of the link clicked directly -

By the way a guy I was helping with an xdf spotted this, I just thought I woudl follow it up so its not just me Wink

[img]http://media2.turbosport.co.uk/2013/11/2016032822578657433Screen Shot 2016-03-28 at 21.57.35.png[/img]


You're trying to view XML in a web browser. HTML is XML.

Don't do that. Open them in notepad or a plain text editor if you want to see/edit the plaintext.
_________________
***************************************
TunerPro Author
1989 Trans Am
Back to top
View user's profile Send private message
 

 
Turbosport



Joined: 26 Jun 2006
Posts: 48

PostPosted: Mon Mar 28, 2016 12:03 pm    Post subject: Reply with quote

I have always just clicked the link and copied the text into a text file with an xdf extension.

Works on some now not others, so some are formatted differently.

Doesn't everyone just click the link and copy ?
Back to top
View user's profile Send private message
 

 
Mangus
TunerPro Author


Joined: 19 Mar 2003
Posts: 1810

PostPosted: Mon Mar 28, 2016 12:05 pm    Post subject: Reply with quote

That's a bad practice on your part. The files are fine, as you can prove yourself by opening them in a plain text editor.

Right-click, save link as.
_________________
***************************************
TunerPro Author
1989 Trans Am
Back to top
View user's profile Send private message
 

 
Turbosport



Joined: 26 Jun 2006
Posts: 48

PostPosted: Mon Mar 28, 2016 12:09 pm    Post subject: Reply with quote

Mangus wrote:
That's a bad practice on your part. The files are fine, as you can prove yourself by opening them in a plain text editor.

Right-click, save link as.


ok I'll update my help files, would be nice if they all behaved the same though.
Back to top
View user's profile Send private message
 

 
Mangus
TunerPro Author


Joined: 19 Mar 2003
Posts: 1810

PostPosted: Mon Mar 28, 2016 12:20 pm    Post subject: Reply with quote

There are two different XDF formats - old and new. New is XML. Don't expect to view raw XML in your browser without the browser trying to render it like HTML (like you see in your third screenshot). Old format will probably work just fine in your browser (like your first screenshot). That's probably the difference you're seeing.

Thanks, though.
_________________
***************************************
TunerPro Author
1989 Trans Am
Back to top
View user's profile Send private message
 

Display posts from previous:   
View previous topic :: View next topic  
Post new topic   Reply to topic    TunerPro User Forum Forum Index -> Report A Bug All times are GMT - 9 Hours
 
Page 1 of 1
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
 


Powered by phpBB © 2001, 2002 phpBB Group
RedSquare theme 1.0.3 © DoubleJ(Jan Jaap)